jolshan commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1819483351
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##########
@@ -418,10 +433,23 @@ class TransactionMarkerChannelManagerTest {
assertEquals(0,
channelManager.queueForBroker(broker2.id).get.totalNumMarkers(txnTopicPartition2))
}
- @Test
- def shouldCompleteAppendToLogOnEndTxnWhenSendMarkersSucceed(): Unit = {
+ @ParameterizedTest
+ @ValueSource(booleans = Array(true, false))
+ def
shouldCompleteAppendToLogOnEndTxnWhenSendMarkersSucceed(isTransactionV2Enabled
: Boolean): Unit = {
mockCache()
+ // Adjust txn metadata based on the transaction version.
Review Comment:
Can we make this a helper method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
