rreddy-22 commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1809228815
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -762,7 +764,7 @@ synchronized void maybeResolveSequences() {
// For the transactional producer, we bump the epoch
if possible, otherwise we transition to a fatal error
String unackedMessagesErr = "The client hasn't
received acknowledgment for some previously " +
"sent messages and can no longer retry them. ";
- if (canBumpEpoch()) {
+ if (!isTransactionV2Enabled && canBumpEpoch()) {
Review Comment:
Maybe we should also rename epochBumpReuired to manualEpochBumpRequired or
clientInitiatedEpochBumpRequired, and instead of using transactionV2Enabled as
a flag everywhere, we use either manual or automatic epoch bumps as conditions.
In the comments we can specify that this is only possible when V2 is enabled
etc. And we should probably be able to move the logic of
"coordinatorSupportsBumpingEpoch" also into one of these categories or merge
logic for that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
