m1a2st commented on code in PR #16899:
URL: https://github.com/apache/kafka/pull/16899#discussion_r1806349957
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -355,6 +355,14 @@ public Map<String, Object>
valuesWithPrefixAllOrNothing(String prefix) {
return nonInternalConfigs;
}
+ protected void clearConfig(String key) {
+ Object value = values.get(key);
+ if (value instanceof Number)
+ values.put(key, 0);
+ else
+ values.remove(key);
+ }
Review Comment:
It seens can resolve `logAll` which will misdirect problem, however I'm
concerned it may not be the best solution. This approach would require
`GroupRebalanceConfig` to be aware of both `ConsumerConfig` and `ProtocolType`,
introducing unnecessary complexity as these config classes would depend on each
other.
To avoid this, we have filed a new [JIRA
ticket](https://issues.apache.org/jira/browse/KAFKA-17821) to focus
specifically on this issue. For now, we can concentrate on improving
`ConsumerConfig` in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
