matt-welch commented on code in PR #17340:
URL: https://github.com/apache/kafka/pull/17340#discussion_r1805546480
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -75,7 +75,13 @@ void start(String[] args) throws IOException {
// not thread-safe, do not share with other threads
SplittableRandom random = new SplittableRandom(0);
ProducerRecord<byte[], byte[]> record;
- stats = new Stats(config.numRecords, 5000);
+ if (config.warmupRecords > 0) {
+ // TODO: Keep this message? Maybe unnecessary
+ System.out.println("Warmup first " + config.warmupRecords + "
records. Steady-state results will print after the complete-test summary.");
Review Comment:
I like this to explicitly inform the user that they're in steady state.
The wording is up for debate, but I've added a basic message "Beginning
steady state" to the record() method to indicate to the user that following
prints are steady state. In testing, I've observed that you might not see
window prints for different number of records, depending on how you set your
warmup records, relative the size of the print window. This is similar to
behavior in the existing test where the final window gets included in the final
summary print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
