mimaison commented on code in PR #17507: URL: https://github.com/apache/kafka/pull/17507#discussion_r1804521410
########## core/src/main/scala/kafka/admin/ConfigCommand.scala: ########## @@ -64,23 +60,19 @@ import scala.collection._ * Alternatively, --user-defaults, --client-defaults, --broker-defaults, or --ip-defaults may be specified in place of * --entity-type <users|clients|brokers|ips> --entity-default, respectively. * - * For most use cases, this script communicates with a kafka cluster (specified via the - * `--bootstrap-server` option). There are three exceptions where direct communication with a - * ZooKeeper ensemble (specified via the `--zookeeper` option) is allowed: + * For most use cases, this script communicates with a Kafka cluster (specified via the + * `--bootstrap-server` option). * - * 1. Describe/alter user configs where the config is a SCRAM mechanism name (i.e. a SCRAM credential for a user) - * 2. Describe/alter broker configs for a particular broker when that broker is down - * 3. Describe/alter broker default configs when all brokers are down + * This script no longer directly communicates with a ZooKeeper ensemble. Review Comment: We don't need to mention ZooKeeper at all. Let's remove all mentions ########## core/src/test/java/kafka/admin/ConfigCommandTest.java: ########## @@ -16,10 +16,6 @@ */ Review Comment: It looks like there are a few unused methods in this file, for example `checkEntity()`, `checkInvalidArgs()`, `checkInvalidEntity()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
