apoorvmittal10 commented on code in PR #17473:
URL: https://github.com/apache/kafka/pull/17473#discussion_r1803033950


##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -1248,6 +1257,8 @@ private[kafka] class Processor(
       if (address != null)
         connectionQuotas.dec(listenerName, address)
       selector.close(connectionId)
+      // Call listeners to notify for closed connection.
+      connectionDisconnectListeners.foreach(listener => CoreUtils.swallow(() 
-> listener.onDisconnect(connectionId), this, Level.ERROR))

Review Comment:
   Yeah, while implementing I thought to have processor id prior from 
`monotonically_increasing_number` as the `monotonically_increasing_number` 
belongs to processor id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to