m1a2st commented on PR #17440: URL: https://github.com/apache/kafka/pull/17440#issuecomment-2415794828
Sorry for late to reply you, Thanks @kirktrue suggestions, I find a good way to resolve the close problem, the `TopicAuthorizationException`[1] is similar with `InvalidTopicException`, thus I think I can add an `or` check in this if else condition [2], it is more clear and simplify [1] https://github.com/apache/kafka/blob/604564cce3e195eece6927dc83d150e0150022fc/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java#L1232 [2] https://github.com/apache/kafka/blob/604564cce3e195eece6927dc83d150e0150022fc/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java#L1283 > Please take a look at @lianetm's comments on [KAFKA-17696](https://issues.apache.org/jira/browse/KAFKA-17696) again as I think she has some suggestions worth pursuing. I will take more deep think in these comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
