chia7712 commented on code in PR #17484:
URL: https://github.com/apache/kafka/pull/17484#discussion_r1800728457
##########
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##########
@@ -135,7 +135,7 @@ class CoreUtilsTest extends Logging {
try {
Await.result(Future.traverse(1 to count) { _ =>
Future {
- CoreUtils.atomicGetOrUpdate(map, 0, {
+ map.getOrElseUpdate(0, {
Review Comment:
If I recall correctly, the discussion focused on performance rather than
behavior correction. If the behavior is inconsistent or incorrect, we should
never replace it. So +1 to removing this test.
@frankvicky, could you please share the JMH results? The concern was about
potential regressions in read-heavy scenarios
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
