hachikuji commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2411832933
I am pretty sure we never had logic to do even a best-effort `LeaveGroup` after an interrupt, so all of the trickery in this patch to try and handle interrupts makes me suspicious. When calling `close()` with a timeout of 0, I think we did something like this: ``` client.send(LeaveGroup) client.poll(0) client.close() ``` (Correct me if I'm wrong.) I'd be interested to know how reliably the `LeaveGroup` actually got sent. Probably works in local testing, but how about for a remote hop? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
