smjn commented on code in PR #17467: URL: https://github.com/apache/kafka/pull/17467#discussion_r1796705828
########## core/src/main/scala/kafka/tools/DumpLogSegments.scala: ########## @@ -628,6 +630,68 @@ object DumpLogSegments { } } + // for test visibility Review Comment: It's already with other MessageParser specializations: order ``` class OffsetsMessageParser extends MessageParser[String, String] private class ClusterMetadataLogMessageParser extends MessageParser[String, String] private class RemoteMetadataLogMessageParser extends MessageParser[String, String] class ShareGroupStateMessageParser extends MessageParser[String, String] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org