chenyulin0719 commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1795951097
########## core/src/test/scala/integration/kafka/api/PlaintextConsumerSubscriptionTest.scala: ########## @@ -227,11 +228,29 @@ class PlaintextConsumerSubscriptionTest extends AbstractConsumerTest { @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames) @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll")) - def testSubscribeInvalidTopic(quorum: String, groupProtocol: String): Unit = { - // Invalid topic name due to space - val invalidTopicName = "topic abc" + def testSubscribeInvalidTopicCanUnsubscribe(quorum: String, groupProtocol: String): Unit = { + val consumer = createConsumer() + + setupSubscribeInvalidTopic(consumer) + assertDoesNotThrow(new Executable { + override def execute(): Unit = consumer.unsubscribe() Review Comment: Jira created, I will dive into it and propose a solution ASAP. - https://issues.apache.org/jira/browse/KAFKA-17769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org