AndrewJSchofield commented on code in PR #17452:
URL: https://github.com/apache/kafka/pull/17452#discussion_r1795732172
##########
clients/src/main/resources/common/message/ShareFetchResponse.json:
##########
@@ -33,15 +33,15 @@
// - INVALID_REQUEST (version 0+)
// - UNKNOWN_SERVER_ERROR (version 0+)
"fields": [
- { "name": "ThrottleTimeMs", "type": "int32", "versions": "0+",
"ignorable": true,
+ { "name": "ThrottleTimeMs", "type": "int32", "versions": "0+",
"about": "The duration in milliseconds for which the request was
throttled due to a quota violation, or zero if the request did not violate any
quota." },
- { "name": "ErrorCode", "type": "int16", "versions": "0+", "ignorable":
true,
+ { "name": "ErrorCode", "type": "int16", "versions": "0+",
"about": "The top-level response error code." },
{ "name": "ErrorMessage", "type": "string", "versions": "0+",
"nullableVersions": "0+", "default": "null",
"about": "The top-level error message, or null if there was no error." },
- { "name": "Responses", "type": "[]ShareFetchableTopicResponse",
"versions": "0+",
+ { "name": "Responses", "type": "[]ShareFetchableTopicResponse",
"versions": "0+",
"about": "The response topics.", "fields": [
- { "name": "TopicId", "type": "uuid", "versions": "0+", "ignorable":
true, "about": "The unique topic ID."},
+ { "name": "TopicId", "type": "uuid", "versions": "0+", "about": "The
unique topic ID."},
{ "name": "Partitions", "type": "[]PartitionData", "versions": "0+",
"about": "The topic partitions.", "fields": [
{ "name": "PartitionIndex", "type": "int32", "versions": "0+",
Review Comment:
This definition is in common with `ShareFetch`. Seems sensible to keep them
the same. Actually, I am going to do another pass of the KIP-932 RPCs and see
if I can gain benefit from `mapKey` annotations for the sake of efficiency.
There's code change off the back of that too, so I didn't do it in the same PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
