chia7712 commented on code in PR #17397:
URL: https://github.com/apache/kafka/pull/17397#discussion_r1795105668
##########
.github/scripts/junit.py:
##########
@@ -78,6 +83,56 @@ class TestSuite:
passed_tests: List[TestCase]
+# Java method names can start with alpha, "_", or "$". Following characters
can also include digits
+method_matcher = re.compile(r"([a-zA-Z_$][a-zA-Z0-9_$]+).*")
+
+
+def clean_test_name(test_name: str) -> str:
+ cleaned = test_name.strip("\"").rstrip("()")
+ m = method_matcher.match(cleaned)
+ return m.group(1)
+
+
+class TestCatalogExporter:
+ def __init__(self):
+ self.all_tests = {} # module -> class -> set of methods
+
+ def handle_suite(self, module: str, suite: TestSuite):
+ if module not in self.all_tests:
+ self.all_tests[module] = OrderedDict()
+
+ for test in suite.failed_tests:
+ if test.class_name not in self.all_tests[module]:
+ self.all_tests[module][test.class_name] = set()
+
self.all_tests[module][test.class_name].add(clean_test_name(test.test_name))
+ for test in suite.passed_tests:
+ if test.class_name not in self.all_tests[module]:
+ self.all_tests[module][test.class_name] = set()
+
self.all_tests[module][test.class_name].add(clean_test_name(test.test_name))
+
+ def export(self, out_dir: str):
+ if not os.path.exists(out_dir):
+ logger.debug(f"Creating output directory {out_dir} for test
catalog export.")
+ os.makedirs(out_dir)
+
+ total_count = 0
+ for module, module_tests in self.all_tests.items():
+ sorted_tests = {}
+ count = 0
+ for test_class, methods in module_tests.items():
+ sorted_methods = sorted(methods)
+ count += len(sorted_methods)
+ sorted_tests[test_class] = sorted_methods
+
+ out_path = os.path.join(out_dir, f"{module}.yaml")
+ logger.debug(f"Writing {count} tests for {module} into
{out_path}.")
+ total_count += 0
Review Comment:
`total_count += count`
##########
.github/scripts/junit.py:
##########
@@ -177,8 +236,14 @@ def pretty_time_duration(seconds: float) -> str:
flaky_table = []
skipped_table = []
+ exporter = TestCatalogExporter()
+
logger.debug(f"::group::Parsing {len(reports)} JUnit Report Files")
for report in reports:
+ # Test report paths look like
module/[test,quarantinedTest]/TEST-class.method.xml
+ report_path = pathlib.Path(report)
+ module_name = report_path.parent.parent.name
+ print(f"Module: {module_name}")
Review Comment:
`logger.debug`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
