chia7712 commented on code in PR #17353:
URL: https://github.com/apache/kafka/pull/17353#discussion_r1795051834
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -1512,14 +1512,15 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
assertEquals(expectedLEO,
brokers.head.replicaManager.localLog(topicPartition).get.logEndOffset)
}
- @ParameterizedTest
- @ValueSource(strings = Array("kraft"))
- def testOffsetsForTimesAfterDeleteRecords(quorum: String): Unit = {
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
+ def testOffsetsForTimesAfterDeleteRecords(quorum: String, groupProtocol:
String): Unit = {
Review Comment:
```
assertNull(consumer.offsetsForTimes(Map(topicPartition ->
JLong.valueOf(0L)).asJava).get(topicPartition))
```
Could you please also check `containsKey(topicPartition)`? As we discussed
before, it should return true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
