apoorvmittal10 commented on PR #17431: URL: https://github.com/apache/kafka/pull/17431#issuecomment-2404477620
Thanks for the review. > What is the purpose of the 'terminating' flag? It seems the flag is used to prevent clients from sending push requests to a 'terminating' `clientInstance`. Why not just remove the instance when `terminating=true`? > > On a related note, it appears that a terminating client instance still updates the expiration timer task while processing push requests. Won't that delay the cache cleanup? If I get it right then we mean that when `terminating` flag in broker request is set to true then rather waiting for timeout we shall remove the instance right away from the cache. That makes sense, I agree. Shall I create a task for that and take it up separaetly as that will be an improvement and this PR solves a critical issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
