cmccabe commented on code in PR #17284:
URL: https://github.com/apache/kafka/pull/17284#discussion_r1777774756
##########
core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala:
##########
@@ -19,83 +19,35 @@ package kafka.coordinator.transaction
import kafka.network.SocketServer
import kafka.server.IntegrationTestUtils
-import kafka.test.{ClusterConfig, ClusterInstance}
-import kafka.test.annotation.{AutoStart, ClusterConfigProperty,
ClusterTemplate, ClusterTest, ClusterTestDefaults, ClusterTests, Type}
+import kafka.test.ClusterInstance
+import kafka.test.annotation.{ClusterConfigProperty, ClusterTest,
ClusterTestDefaults, ClusterTests, Type}
import kafka.test.junit.ClusterTestExtensions
import org.apache.kafka.common.message.InitProducerIdRequestData
import org.apache.kafka.common.network.ListenerName
import org.apache.kafka.common.protocol.Errors
import org.apache.kafka.common.record.RecordBatch
import org.apache.kafka.common.requests.{InitProducerIdRequest,
InitProducerIdResponse}
-import org.apache.kafka.server.config.ReplicationConfigs
import org.apache.kafka.server.common.MetadataVersion
import org.junit.jupiter.api.Assertions.{assertEquals, assertTrue}
import org.junit.jupiter.api.extension.ExtendWith
-import org.junit.jupiter.api.{Disabled, Timeout}
import java.util.stream.{Collectors, IntStream}
import scala.concurrent.duration.DurationInt
import scala.jdk.CollectionConverters._
-object ProducerIdsIntegrationTest {
- def uniqueProducerIdsBumpIBP(): java.util.List[ClusterConfig] = {
- val serverProperties =
java.util.Collections.singletonMap(ReplicationConfigs.INTER_BROKER_PROTOCOL_VERSION_CONFIG,
"2.8")
- val perBrokerProperties: java.util.Map[Integer, java.util.Map[String,
String]] =
- java.util.Collections.singletonMap(0,
-
java.util.Collections.singletonMap(ReplicationConfigs.INTER_BROKER_PROTOCOL_VERSION_CONFIG,
"3.0-IV0"))
-
- List(ClusterConfig.defaultBuilder()
- .setTypes(Set(Type.ZK).asJava)
- .setBrokers(3)
- .setAutoStart(false)
- .setServerProperties(serverProperties)
- .setPerServerProperties(perBrokerProperties)
- .build()).asJava
- }
-}
-
@ClusterTestDefaults(serverProperties = Array(
new ClusterConfigProperty(key = "transaction.state.log.num.partitions",
value = "1")
))
@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
class ProducerIdsIntegrationTest {
@ClusterTests(Array(
- new ClusterTest(types = Array(Type.ZK), brokers = 3, metadataVersion =
MetadataVersion.IBP_2_8_IV1),
- new ClusterTest(types = Array(Type.ZK), brokers = 3, metadataVersion =
MetadataVersion.IBP_3_0_IV0),
new ClusterTest(types = Array(Type.KRAFT), brokers = 3, metadataVersion =
MetadataVersion.IBP_3_3_IV0)
))
def testUniqueProducerIds(clusterInstance: ClusterInstance): Unit = {
verifyUniqueIds(clusterInstance)
}
- @ClusterTemplate("uniqueProducerIdsBumpIBP")
Review Comment:
These specific tests in `ProducerIdsIntegrationTest` are only relevant to ZK
mode, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
