xijiu commented on code in PR #17231:
URL: https://github.com/apache/kafka/pull/17231#discussion_r1767827389
##########
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##########
@@ -47,7 +47,7 @@
* controller should be able to transition from standby to active without
reloading all of
* the metadata. The standby is a "hot" standby, not a "cold" one.
*/
-public class QuorumConfig {
+public class QuorumConfig extends AbstractConfig {
Review Comment:
> Does it need to extend `AbstractConfig` if it's constructor accepts a
`AbstractConfig` already?
Indeed, having it extend AbstractConfig is unnecessary. And I have removed
it. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
