dongnuo123 commented on code in PR #17008:
URL: https://github.com/apache/kafka/pull/17008#discussion_r1734847464


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2047,6 +2061,10 @@ private CoordinatorResult<Void, CoordinatorRecord> 
classicGroupJoinToConsumerGro
                 scheduleConsumerGroupSyncTimeout(groupId, response.memberId(), 
request.rebalanceTimeoutMs());
 
                 responseFuture.complete(response);
+
+                // Maybe downgrade the consumer group if the last member using 
the
+                // consumer protocol is replaced by the joining member.
+                scheduleConsumerGroupDowngradeTimeout(groupId);

Review Comment:
   I guess we can have something like
   ```
   if (validateDowngrade(group)) {
       scheduleDowngrade(groupId)
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to