dajac commented on code in PR #17013:
URL: https://github.com/apache/kafka/pull/17013#discussion_r1734622172
##########
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##########
@@ -246,21 +247,48 @@ public Map<Integer, ControllerServer> controllers() {
public void format() throws Exception {
if (formated.compareAndSet(false, true)) {
- List<ApiMessageAndVersion> records = new ArrayList<>();
- records.add(
- new ApiMessageAndVersion(new FeatureLevelRecord().
- setName(MetadataVersion.FEATURE_NAME).
-
setFeatureLevel(clusterConfig.metadataVersion().featureLevel()), (short) 0));
-
- clusterConfig.features().forEach((feature, version) -> {
- records.add(
- new ApiMessageAndVersion(new FeatureLevelRecord().
- setName(feature.featureName()).
- setFeatureLevel(version), (short) 0));
+ Map<String, Features> nameToSupportedFeature = new TreeMap<>();
Review Comment:
I checked and I confirm that it is easier to do it once
https://github.com/apache/kafka/pull/16991 is merged or to do it in
https://github.com/apache/kafka/pull/16991. I need some of the code there to
implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
