chia7712 commented on code in PR #16974:
URL: https://github.com/apache/kafka/pull/16974#discussion_r1732216024
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -231,6 +233,15 @@ public ConsumerMembershipManager membershipManager() {
return membershipManager;
}
+ @Override
+ public PollResult pollOnClose(long currentTimeMs) {
Review Comment:
Could you please add the great comment
(https://github.com/apache/kafka/pull/16974#issuecomment-2310463005)
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -231,6 +233,15 @@ public ConsumerMembershipManager membershipManager() {
return membershipManager;
}
+ @Override
+ public PollResult pollOnClose(long currentTimeMs) {
+ if (membershipManager.state() == MemberState.LEAVING) {
+ NetworkClientDelegate.UnsentRequest request =
makeHeartbeatRequest(currentTimeMs, false);
Review Comment:
It is in closing, so maybe we can ignore the response?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
