kevin-wu24 commented on code in PR #16904: URL: https://github.com/apache/kafka/pull/16904#discussion_r1731793016
########## core/src/main/scala/kafka/server/ForwardingManager.scala: ########## @@ -161,9 +178,13 @@ class ForwardingManagerImpl( } } + forwardingManagerMetrics.queueLength.getAndIncrement() channelManager.sendRequest(envelopeRequest, new ForwardingResponseHandler) } + override def close(): Unit = Review Comment: This only closes the metrics and sensors associated with `ForwardingManagerMetrics`, which is only used by `ForwardingManager`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org