AndrewJSchofield commented on code in PR #16955:
URL: https://github.com/apache/kafka/pull/16955#discussion_r1726557420
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -442,14 +453,6 @@ public void acknowledgeSessionUpdate(String groupId,
ShareRequestMetadata reqMet
if (reqMetadata.epoch() == ShareRequestMetadata.INITIAL_EPOCH) {
// ShareAcknowledge Request cannot have epoch as INITIAL_EPOCH (0)
throw Errors.INVALID_SHARE_SESSION_EPOCH.exception();
- } else if (reqMetadata.epoch() == ShareRequestMetadata.FINAL_EPOCH) {
Review Comment:
I don't think this is quite right. If I send in a ShareAcknowledge with
FINAL_EPOCH, then handleShareAcknowledge will call this method with
reqMetadata.epoch() == FINAL_EPOCH. Because this else-if has been removed, it's
going to end up in the next else, and the epoch will not match the request
epoch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
