FrankYang0529 commented on code in PR #16673: URL: https://github.com/apache/kafka/pull/16673#discussion_r1722019888
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java: ########## @@ -118,13 +118,12 @@ private static Stream<Arguments> applicationEvents() { final long currentTimeMs = 12345; return Stream.of( Arguments.of(new PollEvent(100)), - Arguments.of(new NewTopicsMetadataUpdateRequestEvent()), Arguments.of(new AsyncCommitEvent(new HashMap<>())), Arguments.of(new SyncCommitEvent(new HashMap<>(), 500)), Arguments.of(new ResetPositionsEvent(500)), Arguments.of(new ValidatePositionsEvent(500)), Arguments.of(new TopicMetadataEvent("topic", Long.MAX_VALUE)), - Arguments.of(new AssignmentChangeEvent(offset, currentTimeMs))); + Arguments.of(new AssignmentChangeEvent(12345, 12345, Collections.emptyList()))); Review Comment: I add `testAssignmentChangeEvent` and `testAssignmentChangeEventWithException` to check `processor` instance. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org