[
https://issues.apache.org/jira/browse/KAFKA-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613825#comment-16613825
]
ASF GitHub Bot commented on KAFKA-7400:
---------------------------------------
bob-barrett opened a new pull request #5646: KAFKA-7400: Compacted topic
segments that precede the log start offse…
URL: https://github.com/apache/kafka/pull/5646
…t are not cleaned up
Currently we don't delete any log segments if the cleanup policy doesn't
include delete. This patch changes the behavior to delete log segments that
fully precede the log start offset even when deletion is not enabled. Tested
with unit tests to verify that LogManager.cleanupLogs now cleans logs with
cleanup.policy=compact and that Log.deleteOldSegments deletes segments that
preced the start offset regardless of the cleanup policy.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Compacted topic segments that precede the log start offset are not cleaned up
> -----------------------------------------------------------------------------
>
> Key: KAFKA-7400
> URL: https://issues.apache.org/jira/browse/KAFKA-7400
> Project: Kafka
> Issue Type: Bug
> Components: log
> Affects Versions: 1.1.0, 1.1.1, 2.0.0
> Reporter: Bob Barrett
> Assignee: Bob Barrett
> Priority: Minor
>
> LogManager.cleanupLogs currently checks if a topic is compacted, and skips
> any deletion if it is. This means that if the log start offset increases, log
> segments that precede the start offset will never be deleted. The log cleanup
> logic should be improved to delete these segments even for compacted topics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
