pranavrth commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1692910940
##########
clients/src/main/java/org/apache/kafka/common/config/ConfigResource.java:
##########
@@ -33,7 +33,12 @@ public final class ConfigResource {
* Type of resource.
*/
public enum Type {
- CLIENT_METRICS((byte) 16), BROKER_LOGGER((byte) 8), BROKER((byte) 4),
TOPIC((byte) 2), UNKNOWN((byte) 0);
+ GROUP((byte) 32),
Review Comment:
Can we have GROUP(3) instead of GROUP(32) so that it matches with
ResourceType used by ACLs. Ideally and according to KIP-133 Config and ACL APIs
should have same ResourceType. This is the way librdkafka has adopted the
ResourceType. We already have GROUP as `3` in ResourceType and both Config and
ACL APIs use the same resource type enum. We cannot create a new Enum right
away as these are part of the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
