junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684690411
##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit = {
val features = new BrokerRegistrationRequestData.FeatureCollection()
_supportedFeatures.asScala.foreach {
- case (name, range) => features.add(new
BrokerRegistrationRequestData.Feature().
+ // Do not include features with the range 0-0.
+ case (name, range) if range.max() > 0 => features.add(new
BrokerRegistrationRequestData.Feature().
Review Comment:
The main thing is that we need to exclude range 0-0 for supported features
in ApiVersionResponse too. Colin's code in ApiVersionsResponse doesn't seem to
do what you are doing here for BrokerRegistrationRequest by excluding range 0-0
for supported features. It only changes minVersion v0 to v1 for older requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
