abhijeetk88 commented on code in PR #16502:
URL: https://github.com/apache/kafka/pull/16502#discussion_r1680379500
##########
checkstyle/suppressions.xml:
##########
@@ -40,6 +40,7 @@
files="core[\\/]src[\\/](generated|generated-test)[\\/].+.java$"/>
<suppress checks="NPathComplexity"
files="(ClusterTestExtensions|KafkaApisBuilder|SharePartition).java"/>
<suppress
checks="NPathComplexity|ClassFanOutComplexity|ClassDataAbstractionCoupling"
files="(RemoteLogManager|RemoteLogManagerTest).java"/>
+ <suppress checks="MethodLength" files="RemoteLogManager.java"/>
Review Comment:
It is caused by the method _cleanupExpiredRemoteLogSegments_ which is a
little longer now.
> Message: Method length is 173 lines (max allowed is 170).
We have added a few lines in this method to ensure segments that are
currently being copied (but copy isn't complete yet), are not expired by the
expiration task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
