brenden20 commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1678333602
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -201,8 +202,42 @@ public void testSuccessfulHeartbeatTiming() {
@ParameterizedTest
@ApiKeyVersionsSource(apiKey = ApiKeys.CONSUMER_GROUP_HEARTBEAT)
public void
testFirstHeartbeatIncludesRequiredInfoToJoinGroupAndGetAssignments(short
version) {
- resetWithZeroHeartbeatInterval(Optional.of(DEFAULT_GROUP_INSTANCE_ID));
+ membershipManager = new MembershipManagerImpl(
+ DEFAULT_GROUP_ID,
+ Optional.of(DEFAULT_GROUP_INSTANCE_ID),
+ 0,
+ Optional.of(""),
+ subscriptions,
+ mock(CommitRequestManager.class),
+ (ConsumerMetadata) metadata,
+ logContext,
+ Optional.of(mock(ClientTelemetryReporter.class)),
+ backgroundEventHandler,
+ time,
+ new Metrics()
+ );
+ membershipManager.transitionToJoining();
Review Comment:
I was able to get this working with this kind of approach, let me know what
you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
