masonyc commented on code in PR #16563:
URL: https://github.com/apache/kafka/pull/16563#discussion_r1676754850


##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -3768,8 +3779,8 @@ public void 
testHandleLeaderChangeFiresAfterFollowerRegistration(boolean withKip
     public void testObserverFetchWithNoLocalId(boolean withKip853Rpc) throws 
Exception {
         // When no `localId` is defined, the client will behave as an observer.
         // This is designed for tooling/debugging use cases.
-
-        Set<Integer> voters = Utils.mkSet(1, 2);
+        int localId = randomReplicaId();

Review Comment:
   renamed localId to leaderId and removed the previous leaderId line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to