ashoke-cube commented on code in PR #16095:
URL: https://github.com/apache/kafka/pull/16095#discussion_r1672075592
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -134,7 +134,30 @@ public void testInitializeFailure(ConnectorType
connectorType) {
verifyInitialize();
verify(listener).onFailure(CONNECTOR, exception);
- verifyCleanShutdown(false);
+ verifyCleanShutdown(true);
+ }
+
+ @ParameterizedTest
+ @EnumSource(value = ConnectorType.class, names = {"SOURCE", "SINK"})
+ public void testInitializeAndStopFailure() {
Review Comment:
The test failures are not consistent
[1](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-16095/14/tests),
[2](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-16095/13/tests),
[3](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-16095/12/tests)
and seem to be flaky. I have verified the test failures to be not related to
this PR changes. What course of action would you suggest in this case?
@gharris1727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
