rajinisivaram commented on code in PR #16346:
URL: https://github.com/apache/kafka/pull/16346#discussion_r1670076722
##########
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java:
##########
@@ -113,8 +113,12 @@ public Set<String> reconfigurableConfigs() {
}
@Override
- public void validateReconfiguration(Map<String, ?> newConfigs) {
- createNewSslEngineFactory(newConfigs);
+ public void validateReconfiguration(Map<String, ?> newConfigs) throws
ConfigException {
+ try {
+ createNewSslEngineFactory(newConfigs);
+ } catch (IllegalStateException e) {
+ throw new ConfigException("", e);
Review Comment:
As above, should add an exception message?
##########
clients/src/main/java/org/apache/kafka/common/network/SaslChannelBuilder.java:
##########
@@ -190,9 +191,13 @@ public Set<String> reconfigurableConfigs() {
}
@Override
- public void validateReconfiguration(Map<String, ?> configs) {
+ public void validateReconfiguration(Map<String, ?> configs) throws
ConfigException {
if (this.securityProtocol == SecurityProtocol.SASL_SSL)
- sslFactory.validateReconfiguration(configs);
+ try {
+ sslFactory.validateReconfiguration(configs);
+ } catch (IllegalStateException e) {
+ throw new ConfigException("", e);
Review Comment:
Should we add some exception message to say SASL reconfiguration failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
