lianetm commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1668904111
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ########## @@ -349,6 +408,10 @@ public void testNoCoordinator() { when(coordinatorRequestManager.coordinator()).thenReturn(Optional.empty()); NetworkClientDelegate.PollResult result = heartbeatRequestManager.poll(time.milliseconds()); + when(pollTimer.isExpired()).thenReturn(false); + when(pollTimer.remainingMs()).thenReturn(Long.MAX_VALUE); + when(heartbeatRequestState.timeToNextHeartbeatMs(time.milliseconds())).thenReturn(1000L); Review Comment: needed or wanted for some reason? again wondering because since the state is a spy on the internal component, I would expect to have the real implementation kicking in, based on the interval defined for the HBMgr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org