C0urante commented on code in PR #16451:
URL: https://github.com/apache/kafka/pull/16451#discussion_r1667658373


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -231,6 +232,8 @@ public class DistributedHerder extends AbstractHerder 
implements Runnable {
     Thread herderThread;
 
     private final DistributedConfig config;
+    
+    public static Future<?> herderFuture;

Review Comment:
   I don't think this can be `static`; if it is, we won't be able to use it 
with multiple workers in a single integration test (which we do very 
frequently).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to