AndrewJSchofield commented on code in PR #16488:
URL: https://github.com/apache/kafka/pull/16488#discussion_r1666647719
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -808,8 +808,6 @@ void shareAcknowledgement() {
void recordAcknowledgement(byte ackType) {
if (recordAcksSensorMap.containsKey(ackType)) {
Review Comment:
I'd add a comment above the if test that says something like `// unknown ack
types (such as gaps for control records) are intentionally ignored`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
