philipnee commented on code in PR #16200: URL: https://github.com/apache/kafka/pull/16200#discussion_r1664632832
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ########## @@ -594,24 +740,13 @@ public void testHeartbeatState() { @Test public void testPollTimerExpiration() { - coordinatorRequestManager = mock(CoordinatorRequestManager.class); - membershipManager = mock(MembershipManager.class); - heartbeatState = mock(HeartbeatRequestManager.HeartbeatState.class); - heartbeatRequestState = spy(new HeartbeatRequestManager.HeartbeatRequestState( - new LogContext(), - time, - DEFAULT_HEARTBEAT_INTERVAL_MS, - DEFAULT_RETRY_BACKOFF_MS, - DEFAULT_RETRY_BACKOFF_MAX_MS, - 0)); - backgroundEventHandler = mock(BackgroundEventHandler.class); - heartbeatRequestManager = createHeartbeatRequestManager( coordinatorRequestManager, membershipManager, heartbeatState, heartbeatRequestState, backgroundEventHandler); + Review Comment: can we remove the extra space. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org