OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1664131206
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -106,6 +108,17 @@ public void stop() {
Utils.closeQuietly(targetAdminClient, "target admin client");
}
+ @Override
+ public Config validate(Map<String, String> connectorConfigs) {
+ List<ConfigValue> configValues =
super.validate(connectorConfigs).configValues();
+ MirrorCheckpointConfig.validate(connectorConfigs).forEach((config,
errorMsg) ->
+ configValues.stream()
+ .filter(conf -> conf.name().equals(config))
Review Comment:
I moved this to MirrorConnectorConfig which all inherit. So this should be
addressed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
