apoorvmittal10 commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663835968


##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -1246,26 +1250,40 @@ public void testCloseSharePartitionManager() throws 
Exception {
     @Test
     public void testReleaseAcquiredRecordsSuccess() {
         String groupId = "grp";
-        String memberId = Uuid.randomUuid().toString();
+        Uuid memberId = Uuid.randomUuid();

Review Comment:
   Yeah, a conversion from string to Uuid was required later so don't see any 
point in converting to string first then back to Uuid from string. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to