pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1649455825
##########
core/src/test/scala/unit/kafka/admin/AclCommandTest.scala:
##########
@@ -324,12 +348,18 @@ class AclCommandTest extends QuorumTestHarness with
Logging {
}
private def withAuthorizer()(f: Authorizer => Unit): Unit = {
- val kafkaConfig = KafkaConfig.fromProps(brokerProps, doLog = false)
- val authZ = new AclAuthorizer
- try {
- authZ.configure(kafkaConfig.originals)
- f(authZ)
- } finally authZ.close()
+ if (isKRaftTest()) {
+ (servers.map(_.authorizer.get) ++
controllerServers.map(_.authorizer.get)).foreach { auth =>
Review Comment:
> That will create zk authorizer even though the tests don't have zk, right?
Yeah, you are right...
Restored the original implementation :ok_hand:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
