showuon commented on code in PR #16235:
URL: https://github.com/apache/kafka/pull/16235#discussion_r1644362575
##########
clients/src/main/resources/common/message/FetchResponse.json:
##########
@@ -47,7 +47,7 @@
// Version 15 is the same as version 14 (KIP-903).
//
// Version 16 adds the 'NodeEndpoints' field (KIP-951).
- "validVersions": "0-16",
+ "validVersions": "0-17",
Review Comment:
We need to add a comment to mention why we need to bump the version.
##########
clients/src/main/resources/common/message/BeginQuorumEpochResponse.json:
##########
@@ -17,25 +17,35 @@
"apiKey": 53,
"type": "response",
"name": "BeginQuorumEpochResponse",
- "validVersions": "0",
- "flexibleVersions": "none",
+ "validVersions": "0-1",
Review Comment:
Please add a comment to mention what changed in v.1.
##########
clients/src/main/resources/common/message/EndQuorumEpochResponse.json:
##########
@@ -17,25 +17,35 @@
"apiKey": 54,
"type": "response",
"name": "EndQuorumEpochResponse",
- "validVersions": "0",
- "flexibleVersions": "none",
+ "validVersions": "0-1",
Review Comment:
Please add a comment to mention what changed in v.1.
##########
clients/src/main/resources/common/message/FetchSnapshotResponse.json:
##########
@@ -17,7 +17,7 @@
"apiKey": 59,
"type": "response",
"name": "FetchSnapshotResponse",
- "validVersions": "0",
+ "validVersions": "0-1",
Review Comment:
Please add a comment to mention what changed in v.1.
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -440,6 +441,8 @@ class KafkaServer(
threadNamePrefix,
CompletableFuture.completedFuture(quorumVoters),
QuorumConfig.parseBootstrapServers(config.quorumBootstrapServers),
+ // Endpoint information is only needed for controllers (voters).
ZK brokers can never be controllers
+ Endpoints.empty(),
Review Comment:
Should we make it clear that `ZK brokers can never be [KRaft] controllers`.
##########
clients/src/main/resources/common/message/BeginQuorumEpochRequest.json:
##########
@@ -18,24 +18,37 @@
"type": "request",
"listeners": ["controller"],
"name": "BeginQuorumEpochRequest",
- "validVersions": "0",
- "flexibleVersions": "none",
+ "validVersions": "0-1",
Review Comment:
Please add a comment to mention what changed in v.1.
##########
clients/src/main/resources/common/message/EndQuorumEpochRequest.json:
##########
@@ -18,26 +18,41 @@
"type": "request",
"listeners": ["controller"],
"name": "EndQuorumEpochRequest",
- "validVersions": "0",
- "flexibleVersions": "none",
+ "validVersions": "0-1",
Review Comment:
Please add a comment to mention what changed in v.1.
##########
clients/src/main/resources/common/message/FetchSnapshotRequest.json:
##########
@@ -18,7 +18,7 @@
"type": "request",
"listeners": ["controller"],
"name": "FetchSnapshotRequest",
- "validVersions": "0",
+ "validVersions": "0-1",
Review Comment:
Please add a comment to mention what changed in v.1.
##########
clients/src/main/resources/common/message/VoteResponse.json:
##########
@@ -17,29 +17,37 @@
"apiKey": 52,
"type": "response",
"name": "VoteResponse",
- "validVersions": "0",
+ "validVersions": "0-1",
Review Comment:
ditto
##########
clients/src/main/resources/common/message/VoteRequest.json:
##########
@@ -18,30 +18,36 @@
"type": "request",
"listeners": ["controller"],
"name": "VoteRequest",
- "validVersions": "0",
+ "validVersions": "0-1",
Review Comment:
Please add a comment to mention what changed in v.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
