AndrewJSchofield commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1644173569
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3054,6 +3054,8 @@ class KafkaApis(val requestChannel: RequestChannel,
authHelper.authorize(originalRequest.context, ALTER_CONFIGS,
CLUSTER, CLUSTER_NAME)
case ConfigResource.Type.TOPIC =>
authHelper.authorize(originalRequest.context, ALTER_CONFIGS, TOPIC,
resource.name)
+ case ConfigResource.Type.GROUP =>
Review Comment:
I think you also need to add ``` case ConfigResource.Type.GROUP =>
Errors.GROUP_AUTHORIZATION_FAILED``` to `configsAuthorizationApiError`.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -355,7 +370,7 @@ GroupMetadataManager build() {
private final int consumerGroupHeartbeatIntervalMs;
Review Comment:
The comment should probably read "The default heartbeat interval for
consumer groups."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
