soarez commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1642377375
##########
core/src/test/scala/integration/kafka/zk/ZkMigrationFailoverTest.scala:
##########
@@ -274,4 +288,135 @@ class ZkMigrationFailoverTest extends Logging {
if (zkClient != null) Utils.closeQuietly(zkClient, "KafkaZkClient")
}
}
+
+ @Test
+ def testDriverSkipsEventsFromOlderEpoch(): Unit = {
+ val zookeeper = new EmbeddedZookeeper()
+ var zkClient: KafkaZkClient = null
+ val zkConnect = s"127.0.0.1:${zookeeper.port}"
+ try {
+ zkClient = KafkaZkClient(
+ zkConnect,
+ isSecure = false,
+ 30000,
+ 60000,
+ 1,
+ Time.SYSTEM,
+ name = "ZkMigrationFailoverTest",
+ new ZKClientConfig)
+ } catch {
+ case t: Throwable =>
+ Utils.closeQuietly(zookeeper, "EmbeddedZookeeper")
+ zookeeper.shutdown()
Review Comment:
I see you marked this as resolved, and addressed it for lines ~416 but not
for ~309. Was that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
