ableegoldman commented on code in PR #16265:
URL: https://github.com/apache/kafka/pull/16265#discussion_r1637074509


##########
docs/streams/upgrade-guide.html:
##########
@@ -134,11 +134,38 @@ <h3 class="anchor-heading"><a 
id="streams_notable_changes" class="anchor-link"><
     </p>
 
     <h4><a id="streams_api_changes_380" 
href="#streams_api_changes_380">Streams API changes in 3.8.0</a></h3>
+
+    <p>
+        Kafka Streams now supports customizable task assignment strategies via 
the <code>task.assignor.class</code>
+        configuration. The configuration can be set to the fully qualified 
class name of a custom task assignor
+        implementation that has to extend the new
+        
<code>org.apache.kafka.streams.processor.assignment.TaskAssignor</code> 
interface.
+
+        The new configuration also allows users to bring back the behavior of 
the old task assignor
+        <code>StickyTaskAssignor</code> that was used before the introduction 
if
+        <code>HighAvailabilityTaskAssignor</code>. If no custom task assignor 
is configured, the default task assignor
+        <code>HighAvailabilityTaskAssignor</code> is used.
+
+        This change also removes the internal config 
<code>internal.task.assignor.class</code> that was used for the same
+        purpose. If you were using this config, you should switch to using 
<code>task.assignor.class</code> instead.

Review Comment:
   update: we will be renaming the old StickyTaskAssignor class to 
LegacyStickyTaskAssignor (if/when [this 
PR](https://github.com/apache/kafka/pull/16322) is merged) so perhaps we should 
just say something like this:
   
    "If you were using the old internal config 
<code>internal.task.assignor.class</code> to plug in a task assignor, please 
migrate your code to the new public config and pass in an assignor that 
implements the new <code>TaskAssignor</code> interface"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to