abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1635837473
##########
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##########
@@ -817,6 +817,119 @@ class DynamicBrokerConfigTest {
Mockito.verifyNoMoreInteractions(remoteLogManagerMockOpt.get)
}
+ @Test
+ def testRemoteLogManagerCopyQuotaUpdates(): Unit = {
+ val copyQuotaProp =
RemoteLogManagerConfig.REMOTE_LOG_MANAGER_COPY_MAX_BYTES_PER_SECOND_PROP
+
+ val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port
= 9092)
+ val config = KafkaConfig.fromProps(props)
+ val serverMock: KafkaServer = mock(classOf[KafkaServer])
+ val remoteLogManagerMockOpt =
Option(Mockito.mock(classOf[RemoteLogManager]))
+
+ Mockito.when(serverMock.config).thenReturn(config)
+
Mockito.when(serverMock.remoteLogManagerOpt).thenReturn(remoteLogManagerMockOpt)
+
+ config.dynamicConfig.initialize(None, None)
+ config.dynamicConfig.addBrokerReconfigurable(new
DynamicRemoteLogConfig(serverMock))
+
+
assertEquals(RemoteLogManagerConfig.DEFAULT_REMOTE_LOG_MANAGER_COPY_MAX_BYTES_PER_SECOND,
config.getLong(copyQuotaProp))
+
+ // Update default config
+ props.put(copyQuotaProp, "100")
+ config.dynamicConfig.updateDefaultConfig(props)
+ assertEquals(100, config.getLong(copyQuotaProp))
+ Mockito.verify(remoteLogManagerMockOpt.get).updateCopyQuota(100)
+
+ // Update per broker config
+ props.put(copyQuotaProp, "200")
+ config.dynamicConfig.updateBrokerConfig(0, props)
+ assertEquals(200, config.getLong(copyQuotaProp))
+ Mockito.verify(remoteLogManagerMockOpt.get).updateCopyQuota(200)
+
+ Mockito.verifyNoMoreInteractions(remoteLogManagerMockOpt.get)
+ }
+
+ @Test
+ def testRemoteLogManagerFetchQuotaUpdates(): Unit = {
Review Comment:
Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
