artemlivshits commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1628482592
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala:
##########
@@ -75,9 +76,9 @@ object TransactionLog {
.setPartitionIds(partitions.map(tp =>
Integer.valueOf(tp.partition)).toList.asJava)
}.toList.asJava
- // Serialize with the highest supported non-flexible version
- // until a tagged field is introduced or the version is bumped.
- MessageUtil.toVersionPrefixedBytes(0,
+ val version: Short =
Review Comment:
Could we retain and extend the comment to explain the new logic?
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -205,7 +205,10 @@ public enum MetadataVersion {
IBP_3_8_IV0(20, "3.8", "IV0", true),
// Introduce version 1 of the GroupVersion feature (KIP-848).
- IBP_4_0_IVO(21, "4.0", "IV0", false);
+ IBP_4_0_IVO(21, "4.0", "IV0", false),
Review Comment:
Not introduced in this change, but looks like IBP_4_0_IVO uses letter "O" at
the end which is different from other versions that use number "0".
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -205,7 +205,10 @@ public enum MetadataVersion {
IBP_3_8_IV0(20, "3.8", "IV0", true),
// Introduce version 1 of the GroupVersion feature (KIP-848).
- IBP_4_0_IVO(21, "4.0", "IV0", false);
+ IBP_4_0_IVO(21, "4.0", "IV0", false),
+
+ // Introduce version 1 of the TransactionVersion feature (KIP-890).
+ IBP_4_0_IV1(22, "4.0", "IV1", false);
Review Comment:
Do we need a separate MV version? We could bind TV to IBP_4_0_IVO. It's
still in the future, so this should be ok as far as the bootstrap is concerned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
