ganesh-sadanala commented on PR #16162: URL: https://github.com/apache/kafka/pull/16162#issuecomment-2151117769
> With 3 input topic partitions, there should be 3 tasks, one for each partition. But the application must first join the consumer group and the rebalancing must finish, before tasks are created. Do you might want to wait until the app goes into `RUNNING` state? Thank you! However, I made a mistake running the wrong file with older implementation, thus it was still showing ratio as 0. Ran the update file, and with all setup, voila! it woks now! <img width="900" alt="Screenshot 2024-06-05 at 7 20 57 PM" src="https://github.com/apache/kafka/assets/40536512/0c3e37e3-4d00-4673-a94e-473e93888ecf";> > In the end, we should have some unit test anyway? Build it failing right now, due to missing license header in the newly added files. You need to fix this. -- Did you locally run tests? I would hope we have some test coverage already, and would expect that these test would need to get updated, too? License headers are fixed. Regarding Unit tests, I don't see existing test needs any revisal since there is no test already existing testing the punctuate-ratio metric. The existing tests test if all the setup and configuration are done well. Since `punctuate-ratio` can always be >=0, we can't add a test saying it is never 0. Do you have any specific details to be added as a test for checking if any metric value is valid/invalid? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
