kirktrue commented on code in PR #15961: URL: https://github.com/apache/kafka/pull/15961#discussion_r1628244915
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataErrorManager.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer.internals; + +import org.apache.kafka.clients.Metadata; +import org.apache.kafka.clients.consumer.internals.NetworkClientDelegate.PollResult; +import org.apache.kafka.clients.consumer.internals.events.BackgroundEventHandler; +import org.apache.kafka.clients.consumer.internals.events.ErrorEvent; + +public class MetadataErrorManager implements RequestManager { Review Comment: We shouldn't need to make this a `RequestManager`. Can we just create an instance of the `MetadataErrorManager` from the `ConsumerNetworkThread`, and then invoke `maybePropagateMetadataError ` at the appropriate point inside `runOnce()`? ########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataErrorManager.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer.internals; + +import org.apache.kafka.clients.Metadata; +import org.apache.kafka.clients.consumer.internals.NetworkClientDelegate.PollResult; +import org.apache.kafka.clients.consumer.internals.events.BackgroundEventHandler; +import org.apache.kafka.clients.consumer.internals.events.ErrorEvent; + +public class MetadataErrorManager implements RequestManager { + private final Metadata metadata; + private final BackgroundEventHandler backgroundEventHandler; + + public MetadataErrorManager(Metadata metadata, BackgroundEventHandler backgroundEventHandler) { + assert metadata != null; + assert backgroundEventHandler != null; + + this.metadata = metadata; + this.backgroundEventHandler = backgroundEventHandler; + } + + @Override + public PollResult poll(long currentTimeMs) { + maybePropagateMetadataError(); + + return PollResult.EMPTY; + } + + private void maybePropagateMetadataError() { + try { + metadata.maybeThrowAnyException(); + } catch (Exception e) { + backgroundEventHandler.add(new ErrorEvent(e)); + } Review Comment: Ideally these five lines could just be in `ConsumerNetworkThread`, either inline in `runOnce()` or as a separate method. ########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MetadataErrorManager.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer.internals; + +import org.apache.kafka.clients.Metadata; +import org.apache.kafka.clients.consumer.internals.NetworkClientDelegate.PollResult; +import org.apache.kafka.clients.consumer.internals.events.BackgroundEventHandler; +import org.apache.kafka.clients.consumer.internals.events.ErrorEvent; + +public class MetadataErrorManager implements RequestManager { + private final Metadata metadata; + private final BackgroundEventHandler backgroundEventHandler; + + public MetadataErrorManager(Metadata metadata, BackgroundEventHandler backgroundEventHandler) { + assert metadata != null; + assert backgroundEventHandler != null; Review Comment: I don't think we use this style of `assert` anywhere else. We should use `Objects.requireNonNull()` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
