mimaison commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1627267423
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java:
##########
@@ -252,7 +252,13 @@ private static ConfigDef defineCheckpointConfig(ConfigDef
baseConfig) {
ConfigDef.Type.CLASS,
TOPIC_FILTER_CLASS_DEFAULT,
ConfigDef.Importance.LOW,
- TOPIC_FILTER_CLASS_DOC);
+ TOPIC_FILTER_CLASS_DOC)
+ .define(
Review Comment:
I'm not sure I folly understand your question. My main point is that we
should not define the `emit.offset-syncs.enable` configuration on the
checkpoint connector as it has no functional impact and a very limited use in
validating the configuration because the source connector could use a different
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
