FrankYang0529 commented on PR #16105: URL: https://github.com/apache/kafka/pull/16105#issuecomment-2147493572
> @FrankYang0529 , thanks for the PR. My understanding is no one passed `preAppendErrors` into `createPutCacheCallback` method, so it will always be empty. Thus, we can remove it. Is that correct? If so, you might need to update the PR description since this line confused me a little: `However, the pre-append error is handled before by calling responseCallback. Hence, we can remove preAppendErrors.` > > No one handled the preAppendErrors because it will always be empty, is that right? Hi @showuon, thanks for the review. I update description and try to add more context. May you take a look? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
