FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625870476
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##########
@@ -69,35 +91,60 @@ public class DescribeConsumerGroupTest extends
ConsumerGroupCommandTest {
DESCRIBE_TYPES = describeTypes;
}
- @ParameterizedTest(name =
TEST_WITH_PARAMETERIZED_QUORUM_AND_GROUP_PROTOCOL_NAMES)
- @MethodSource({"getTestQuorumAndGroupProtocolParametersAll"})
- public void testDescribeNonExistingGroup(String quorum, String
groupProtocol) {
- createOffsetsTopic(listenerName(), new Properties());
+ DescribeConsumerGroupTest(ClusterInstance clusterInstance) {
+ this.clusterInstance = clusterInstance;
+ }
+
+ private static List<ClusterConfig> generator() {
Review Comment:
In this test, we only run 3 servers, not like default
`ConsumerGroupCommandTestUtils.generator()` running 5 servers. This is to
address https://github.com/apache/kafka/pull/15908#issuecomment-2131274897. Do
we want to change it back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
