lianetm commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1625054713


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##########
@@ -329,6 +382,8 @@ void testEnsureEventsAreCompleted() {
 
     @Test
     void testCleanupInvokesReaper() {
+        LinkedList<NetworkClientDelegate.UnsentRequest> queue = new 
LinkedList<>();
+        when(networkClientDelegate.unsentRequests()).thenReturn(queue);

Review Comment:
   totally needed, but heads-up, there is another 
[PR](https://github.com/apache/kafka/pull/16156) in-flight where we're trying 
to change the check behind this, so we'll need to update this expectation here 
if that goes in first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to